diff options
Diffstat (limited to 'internal/slug')
| -rw-r--r-- | internal/slug/slug.go | 12 | ||||
| -rw-r--r-- | internal/slug/slug_test.go | 9 |
2 files changed, 18 insertions, 3 deletions
diff --git a/internal/slug/slug.go b/internal/slug/slug.go index a3c99a4..197160c 100644 --- a/internal/slug/slug.go +++ b/internal/slug/slug.go @@ -27,6 +27,15 @@ var greek = strings.NewReplacer( // Make returns a slug for s; falls back to "untitled" when nothing usable remains. func Make(s string) string { + if s = Clean(s); s == "" { + return "untitled" + } + return s +} + +// Clean is Make without the fallback: "" when nothing usable remains, so a +// caller can reject the input (a tag) rather than name it "untitled". +func Clean(s string) string { if t, _, err := transform.String(stripMarks, s); err == nil { s = t } @@ -36,9 +45,6 @@ func Make(s string) string { if len(s) > 80 { s = strings.Trim(s[:80], "-") } - if s == "" { - return "untitled" - } return s } diff --git a/internal/slug/slug_test.go b/internal/slug/slug_test.go index 9953f34..59e2a75 100644 --- a/internal/slug/slug_test.go +++ b/internal/slug/slug_test.go @@ -20,6 +20,15 @@ func TestMake(t *testing.T) { } } +func TestClean(t *testing.T) { + cases := map[string]string{"!!!": "", "": "", "Ντομάτες": "ntomates", "Go ": "go"} + for in, want := range cases { + if got := Clean(in); got != want { + t.Errorf("Clean(%q) = %q, want %q", in, got, want) + } + } +} + func TestValid(t *testing.T) { for _, ok := range []string{"a", "abc-def", "a1-b2"} { if !Valid(ok) { |
